window-rules: fix view-action-interface output detection logic#2976
Merged
ammen99 merged 4 commits intoWayfireWM:masterfrom Feb 22, 2026
Merged
window-rules: fix view-action-interface output detection logic#2976ammen99 merged 4 commits intoWayfireWM:masterfrom
ammen99 merged 4 commits intoWayfireWM:masterfrom
Conversation
Contributor
Author
|
i found a regression. when wstroke plugin is enabled, activating the button modifier causes system to freeze. wstroke probably not expecting output names other than the connector names. EDIT: turns out this problem with wstroke did not come from this PR. It was an issue with the wstroke plugin itself which is being fixed. dkondor/wstroke#18 |
ammen99
approved these changes
Feb 20, 2026
Member
ammen99
left a comment
ammen99
left a comment
There was a problem hiding this comment.
One small nitpick, otherwise lgtm.
| std::string model = wo->handle->model ? wo->handle->model : ""; | ||
| std::string serial = wo->handle->serial ? wo->handle->serial : ""; | ||
|
|
||
| LOGD("Output detected: connector=", wo->to_string(), |
Member
There was a problem hiding this comment.
This one would be way too verbose I think, I would prefer to remove it.
Contributor
Author
There was a problem hiding this comment.
yes i can remove lines 547-550.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added logic so the make+model+serial number could be used with window-rules in addition to the usual connector names like DP-1, HDMI-A-1. This helps when connector names change especially when using a laptop dock connected to external monitors.
I had to update literal.cpp in wf-utils. see separate PR for that. thanks